Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Copy Unit" button should be behind enable_copy_paste_units flag #33867

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: "Copy Unit" button should be behind enable_copy_paste_units flag #33867

merged 1 commit into from
Dec 1, 2023

Conversation

bradenmacdonald
Copy link
Contributor

Description

This is a quick follow-up and fix for #33724 . The new Copy Unit button was appearing regardless of the contentstore.enable_copy_paste_units waffle flag. And once a unit was copied, the other new functionality could become visible.

This fixes the button so that it only appears when the contentstore.enable_copy_paste_units feature flag is explicitly enabled.

Screenshot 2023-12-01 at 12 45 38 PM

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 1, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald bradenmacdonald merged commit 99667f6 into openedx:master Dec 1, 2023
64 checks passed
@bradenmacdonald bradenmacdonald deleted the copy-unit-fix branch December 1, 2023 21:35
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@open-craft-grove
Copy link

Sandbox destroy request received.

2 similar comments
@open-craft-grove
Copy link

Sandbox destroy request received.

@open-craft-grove
Copy link

Sandbox destroy request received.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

@yusuf-musleh yusuf-musleh Awaiting requested review from yusuf-musleh

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradenmacdonald @openedx-webhooks @open-craft-grove @edx-pipeline-bot @robrap